On Fri, 29 Aug 2003 20:39:22 GMT, "John B. Matthews"
<nospam@nospam.com> wrote:

>Rob, Chris & Co:
>
>I'm starting a new thread in case others are working with 
>AppleCommander. I found a few problems with Pascal dates in 
>v1.2.3.
(SNIP)


You said you're working on the ProDOS side...

I just noticed a bug in the DATE formatting.  It's off by 1 month
(adding 1 month to the real date.)

What should be "6-MAY-93" is showing up as "06/06/1993"
and "6-DEC-91" is showing up as "01/06/1992".

Just noticed this while doing my "DIR" command and checking it against
a real CATALOG of my ProDOS disk running in AppleWin.

// CHRIS




On Fri, 29 Aug 2003 20:39:22 GMT, "John B. Matthews"
<nospam@nospam.com> wrote:

>Rob, Chris & Co:
>
>I'm starting a new thread in case others are working with 
>AppleCommander. I found a few problems with Pascal dates in 
>v1.2.3.
(SNIP)
>John
>----
>jmatthews at wright dot edu
>www dot wright dot edu/~john.matthews/

Just working on my "GET" routine for ProDOS, and it seems that there's
a bug in the FormattedDisk.getFile(List files, String filename)
function.

I have it searching for a file that appears AFTER an entry that is a
directory.  The routine never searches for any root-level files after
the first root-level directory is found.

Here's the original function from FormattedDisk.java:

protected FileEntry getFile(List files, String filename) {
  FileEntry theFileEntry = null;
  if (files != null) {
    for (int i=0; i<files.size(); i++) {
      FileEntry entry = (FileEntry) files.get(i);
      if (entry.isDirectory()) {
        theFileEntry = getFile(
          ((DirectoryEntry)entry).getFiles(), filename);
        break;
      }
      String otherFilename = entry.getFilename();
      if (otherFilename != null) otherFilename = otherFilename.trim();
      if (filename.equalsIgnoreCase(otherFilename)) {
        theFileEntry = entry;
        break;
      }
    }
  }
  return theFileEntry;
}

That first "break;" in the "if(entry.isDirectory())" statement should
be something like "if(theFileEntry != null) break;" so that it will
keep searching if it didn't find the file.  Once I changed that, it
worked and found the file I was going after.

// CHRIS




On Mon, 01 Sep 2003 20:01:16 -0400, Chris Morse <chris@cosmicwolf.com>
wrote:

>On Fri, 29 Aug 2003 20:39:22 GMT, "John B. Matthews"
><nospam@nospam.com> wrote:
>
>>Rob, Chris & Co:
>>
>>I'm starting a new thread in case others are working with 
>>AppleCommander. I found a few problems with Pascal dates in 
>>v1.2.3.
(SNIP)
>That first "break;" in the "if(entry.isDirectory())" statement should
>be something like "if(theFileEntry != null) break;" so that it will
>keep searching if it didn't find the file.  Once I changed that, it
>worked and found the file I was going after.
>
>// CHRIS


Something else to think about..  for ProDOS disks..

the "getFile()" function in FormattedDisk.java does a brute force
search of the specified filename.  As it says in the comments, it will
find and return the FIRST matching filename.  So if you have two
subdirectories each with a file called "TEST", then it will ALWAYS
pick up the first one and NEVER the second one.

How about enhancing this?  Ideally, I would have it require absolute
paths.  So that you must specify "DIRNAME/FILENAME" to specify a file
in a directory... 

What do you think?

If you don't have time or the inclination, I will probably rewrite the
function to accept fully-qualified filenames... not sure WHEN tho!

Not sure how it would affect Pascal disks.. I haven't played around
with them yet..

Cheers!
// CHRIS