"John B. Matthews" <nospam@nospam.com> wrote in news:nospam-
743029.18495801092003@clmboh1-nws3.columbus.rr.com:

> I see that TextFileFilter ignores Apple2 line endings. Does this 
> work on Windows? I've temporarily translated CR to LF for 
> testing. I'm thinking about revising TextFileFilter to use a 
> PrintWriter, as it works well in ApplesoftFileFilter. Would this 
> be the correct cross-platform choice?

That's a good question.  I think PrintWriter may help - the 
TextFileFilter will have to be modified, but that shouldn't be too bad.

I used the following code: (in a scrapbook page)

    // Seeing if ByteArrayOutputStream captures CR/LF...
    java.io.ByteArrayOutputStream baos = 
        new java.io.ByteArrayOutputStream();
    java.io.PrintWriter pw = new java.io.PrintWriter(baos);
    pw.print("Hello!");
    pw.println();
    pw.print("Bye!");
    pw.close();
    baos.close();
    byte[] bytes = baos.toByteArray();
    System.out.println("length = " + bytes.length);
    for (int i=0; i<bytes.length; i++) {
        System.out.print(bytes[i]);
        System.out.print(' ');
    }

The results under Windows was:
    length = 12
    72 101 108 108 111 33 13 10 66 121 101 33 
This should be:
    H  e   l   l   o   !  CR LF B  y   e   !

I then wrote a quick Java application under Linux and ran it there with 
the following results:
    length = 11
    72 101 108 108 111 33 10 66 121 101 33 
That is:
    H  e   l   l   o   !  LF B  y   e   !


I think that answers the question/problem?  Presumably, with what you've 
started, continue modifying to use ByteArrayOutputStream along with 
PrintWriter.  Hopefully this is a cross-platform solution!

If you've already solved it - sorry, but it was fun!!
-Rob



Chris Morse <chris@cosmicwolf.com> wrote in 
news:s5o7lvseeura9qnvopvk169bqm30o5peni@4ax.com:

> the "getFile()" function in FormattedDisk.java does a brute force
> search of the specified filename.  As it says in the comments, it will
> find and return the FIRST matching filename.  So if you have two
> subdirectories each with a file called "TEST", then it will ALWAYS
> pick up the first one and NEVER the second one.
> 
> How about enhancing this?  Ideally, I would have it require absolute
> paths.  So that you must specify "DIRNAME/FILENAME" to specify a file
> in a directory... 
> 
> What do you think?

I did a search, and getFile(String) [public method] is only used in 
DiskHelperTest and ApplesoftCompilerTest.  

Basically, it can get a new calling/enhancement.

Maybe have both a "FileEntry getFile(String)" that can handle paths 
along with a "List getFiles(String)" which returns a list of matching 
files?

I could see this being useful both from the command-line as well as the 
GUI.

Go ahead and take a crack at it - I'm hoping to get both of your 
enhancements and bug fixes to incorporate it into AppleCommander anyway!

The AppleCommander class (application launcher) was originally written 
with the expectation of having SWT-based, Swing-based, as well as a 
command-line based interface.
-Rob